Skip to content

fix(native-input): add correct translate3d for rtl #11817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Khalid-Nowaf
Copy link

@Khalid-Nowaf Khalid-Nowaf commented May 27, 2017

Short description of what this resolves:

"On a IOS devices and RTL Direction" when a user moves from input element to another input element, the cursor get appeared in the middle of the page, also the label gets flicker.

this PR fixes:

  • Input Cursor bug in RTL in IOS device
  • Lable Flicker bug in RTL in IOS device

IOS Device before the fix

Android Device before the fix "not effected"

Changes proposed in this pull request:

  • Check the platform.Dir before setting the translate3d
  • The tx in translate3d in RTL should be 9999, while in LTR -9999

IOS Devie after the fix

Android Device after the fix

**NOTE: the Android does not have this bug, but I'm showing the Android device to confirm the fix has not changed any behaver of input in Android.

Ionic Version:
3.x
Fixes:
#11745 (most of it)
#11211

@Khalid-Nowaf
Copy link
Author

@AmitMY, what do you think?

@AmitMY
Copy link
Contributor

AmitMY commented May 28, 2017

This looks correct and easily mergable.
Not sure how it fixes the problem (as it is off screen), but it makes sense to have the opposite x on RTL.

Thanks for your contribution!

This needs the approval of @manucorporat. Manu what do you think?

@manucorporat
Copy link
Contributor

I could not merge this before I knew native-input.ts was about to disappear...
but your fix was good:

ef85ba6

Thanks a lot!!

@alaa-alshamy alaa-alshamy mentioned this pull request Jun 18, 2017
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants