Remove process.exit when simctl prerequisite does not pass #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The init() function will return a shell return code. In the CLI context, when the return code is non-zero, it will then call process.exit with that return code. Since the behaviour has changed, the version is bumped a major so that dependents don't pick this up automatically and encounter unexpected results.
|
I am in the process of testing this on macOS, Windows 10 and Linux through the CLI context. I'll write up a unit-test for the lib context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The init() function will return a shell return code. In the CLI context, when the return code is non-zero, it will then call process.exit with that return code.
Since the behaviour has changed, the version is bumped a major so that dependents don't pick this up automatically and encounter unexpected results.