Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badger dep (again) and update options code #62

Closed
wants to merge 1 commit into from

Conversation

cap10morgan
Copy link

Badger has reverted their shift to go modules /v2 versioning. There is some talk of un-reverting (re-re-reverting?), but for now the build is broken again. This PR seems to fix it.

@cap10morgan
Copy link
Author

The CI build might need a go clean -modcache or env GOPROXY='https://proxy.golang.org' go clean -modcache to clear out the old badger/v2 stuff.

This was referenced Jun 27, 2019
@Kubuxu
Copy link
Member

Kubuxu commented Jun 27, 2019

I've cleaned travis cache.
Can you update it to @master instead of @latest tag. I don't want to depend on the -rc2 tag which is inconsistent between github and proxy.golang.org.

@campoy
Copy link
Contributor

campoy commented Jun 27, 2019

Please do not merge this, as you will end up depending on a release candidate.

You should be able to simply depend on v1.5.5 and you won't need to change anything compared to the tag v2.0.0-rc.2 which you were depending on.

As I explained on dgraph-io/badger#904 this tag was never supposed to exist, and I mistakenly thought no one would depend on.

@campoy
Copy link
Contributor

campoy commented Jun 27, 2019

I'm happy to send a PR myself, give me a minute.

@Kubuxu
Copy link
Member

Kubuxu commented Jun 27, 2019

@campoy it will be hard for us to downgrade as we have already packages that use the newly broken 2.0.0-rc2.

This would mean that we have to walk through all of our uses of badger and upgrade go-ds-badger so we don't depend on 2.0.0-rc2 at all. It would be much easier if you were to release -rc3 so we don't have to do downgrading.

@Kubuxu
Copy link
Member

Kubuxu commented Jun 27, 2019

On the other hand, we can also upgrade all go-ds-badger uses, it isn't that many.

@campoy
Copy link
Contributor

campoy commented Jun 27, 2019

You are then migrating to v2.0.0 which will use a different file format to the one you're currently using.

I can't stop you from doing so, but please be aware that you are jumping from ~v1.5.3 to v2.0.0.
This is not a backward-compatible change neither on API or data format on disk, so users that already have badger databases stored in disks will not be able to open them with this new version.

Please reconsider this and migrate to v1.5.5, or v1.6.0 which should be released next week.
I'm happy to tag v1.6.0-rc1 right away so you can depend on it, but please do not use v2 before we actually release it.

@Kubuxu
Copy link
Member

Kubuxu commented Jun 27, 2019

Ahh, I was not aware that v2 was changing disk data format. I was under impression that on-disk format was defined stable a while ago.

OK. We will downgrade.

@campoy
Copy link
Contributor

campoy commented Jun 27, 2019

Just give me a minute and I'll send a PR, sorry again about all this mess.

@Kubuxu
Copy link
Member

Kubuxu commented Jun 27, 2019

Thanks!

@campoy
Copy link
Contributor

campoy commented Jun 27, 2019

Sent #65

@Stebalien Stebalien closed this Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants