-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix badger dep (again) and update options code #62
Conversation
The CI build might need a |
I've cleaned travis cache. |
Please do not merge this, as you will end up depending on a release candidate. You should be able to simply depend on v1.5.5 and you won't need to change anything compared to the tag As I explained on dgraph-io/badger#904 this tag was never supposed to exist, and I mistakenly thought no one would depend on. |
I'm happy to send a PR myself, give me a minute. |
@campoy it will be hard for us to downgrade as we have already packages that use the newly broken 2.0.0-rc2. This would mean that we have to walk through all of our uses of badger and upgrade |
On the other hand, we can also upgrade all go-ds-badger uses, it isn't that many. |
You are then migrating to v2.0.0 which will use a different file format to the one you're currently using. I can't stop you from doing so, but please be aware that you are jumping from ~v1.5.3 to v2.0.0. Please reconsider this and migrate to v1.5.5, or v1.6.0 which should be released next week. |
Ahh, I was not aware that v2 was changing disk data format. I was under impression that on-disk format was defined stable a while ago. OK. We will downgrade. |
Just give me a minute and I'll send a PR, sorry again about all this mess. |
Thanks! |
Sent #65 |
Badger has reverted their shift to go modules
/v2
versioning. There is some talk of un-reverting (re-re-reverting?), but for now the build is broken again. This PR seems to fix it.