Skip to content

Fix comment on WithBufferSize #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

Fix comment on WithBufferSize #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dsqueue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ func (q *DSQueue) worker(ctx context.Context, bufferSize, dedupCacheSize int, id
if err := q.ds.Put(ctx, k, nil); err != nil {
log.Errorw("failed to write item to datastore", "err", err, "qname", q.name)
}
counter++
}
if inBuf.Len() != 0 {
err := q.commitInput(ctx, counter, &inBuf)
Expand Down Expand Up @@ -219,6 +218,7 @@ func (q *DSQueue) worker(ctx context.Context, bufferSize, dedupCacheSize int, id
// the input buffer.
item = inBuf.PopFront()
k = makeKey(item, counter)
counter++
}
}

Expand Down
5 changes: 3 additions & 2 deletions option.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@ func getOpts(opts []Option) config {

// WithBufferSize sets the limit on number of items kept in input buffer
// memory, at which they are all written to the datastore. A value of 0 means
// items are only written to the datastore at shutdown, and read from the
// datastore at start.
// the buffer size is unlimited, and items are only written to the datastore
// when the queue has been idle more then the idle write time or when the queue
// is closed.
func WithBufferSize(n int) Option {
return func(c *config) {
if n < 0 {
Expand Down