This repository was archived by the owner on Feb 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 176
Fix Travis Builds #184
Merged
Merged
Fix Travis Builds #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OK unfortunately I don't think we can use the |
It only disables go mod if we ask it to build using gx. Something fishy is going on here. |
Interesting, I wonder if it is due to the way I'm specifying the |
@postables DE_P_TYPE |
excellent catch! everything appears to be all good now :D |
Thanks! |
liujiaxun2018
pushed a commit
to TRON-US/go-btfs-api
that referenced
this pull request
Dec 19, 2019
fix tests and CI build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge yet, trying out a suspected fix(es) to travis buildsGood to merge/reviewedit: Aha!! I've traced the source of issues, it is the way the docker container is started like this
it is unclear in travis that this is what's causing the issue, because you can't actually inspect the state of a docker container. However, running
docker logs <container-id>
gives the followingso the reason for failing tests is quite simple actually, there is no ipfs daemon!