Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

Conversation

bonedaddy
Copy link

@bonedaddy bonedaddy commented May 22, 2019

Do not merge yet, trying out a suspected fix(es) to travis builds Good to merge/review

edit: Aha!! I've traced the source of issues, it is the way the docker container is started like this

docker run -d -v /tmp/ipfs:/data/ipfs -p 8080:8080 -p 4001:4001 -p 5001:5001 ipfs/go-ipfs:master "--enable-pubsub-experiment"

it is unclear in travis that this is what's causing the issue, because you can't actually inspect the state of a docker container. However, running docker logs <container-id> gives the following

Changing user to ipfs
ipfs version 0.4.21-rc2
Found IPFS fs-repo at /data/ipfs
Error: unknown option "enable-pubsub-experiment"

so the reason for failing tests is quite simple actually, there is no ipfs daemon!

@bonedaddy
Copy link
Author

OK unfortunately I don't think we can use the run-standard-tests.sh in this repo, since it seems to be causing major issues with gomod, due to this bit of code here as it appears to be disabling gomod which is then breaking CI builds.

@bonedaddy bonedaddy changed the title Fix Travis Builds (WIP) Fix Travis Builds May 23, 2019
@Stebalien
Copy link
Member

It only disables go mod if we ask it to build using gx. Something fishy is going on here.

@bonedaddy
Copy link
Author

Interesting, I wonder if it is due to the way I'm specifying the DEBTYPE variable, let me shift that to the matrix section of env and see if that helps

@Stebalien
Copy link
Member

@postables DE_P_TYPE

@bonedaddy
Copy link
Author

excellent catch! everything appears to be all good now :D

@Stebalien Stebalien merged commit c173ec7 into ipfs:master May 23, 2019
@Stebalien
Copy link
Member

Thanks!

@bonedaddy bonedaddy deleted the travis/fix branch May 23, 2019 01:28
liujiaxun2018 pushed a commit to TRON-US/go-btfs-api that referenced this pull request Dec 19, 2019
fix tests and CI build.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants