This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Proper Pubsub support #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, that's what I thought. We need to run the daemon with the pubsub experiment enabled. |
|
CR pls @Kubuxu @whyrusleeping @lgierth |
|
This LGTM, thanks @keks ! |
|
Too late, but tests are not passing for this one. Forgot to add new dependencies to Gx.... |
|
Oh, how could that happen? What did I miss and why did it pass before? |
|
I mean there aren't any dependencies in package.json. We could have bumped the version, though. |
|
Fix by retry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I put a lot of effort into making things smooth on the server side. Here is the API code, that ignores the first packet sent because it is only used to force a flush.
Maybe the pubsub test should not be run if the server is not started with pubsub enabled? Don't know how to check that though.