MultiFileReader function Read(buf []byte) commit a wrong path with windows

[godcong]

go-ipfs-files/multifilereader.go

Line 90 in c68472a

filename := url.QueryEscape(path.Join(path.Join(mfr.path...), entry.Name()))

this line will make a file with directory like D:\video\H/p2526321708.webp
in windows this path is not correct.
i'm used rest to get the file information.
it's result the same directory.
but if i fix to D:\video\H\p2526321708.webp
command ipfs ls /ipfs/#pathcode# can't display the sub file with this directory.

[Stebalien]

Where are you observing this behavior? The code you're linking to should always be using unix paths (a/b/c) so I'm not sure where the D:\video\H part is coming from.

[godcong]

in windows,in go.
i written an api like go-ipfs-api
to get the filename in my project,
api was used this function to add dir.

if i used multifilereader to add files,
the post data name was D:\video\H/p2526321708.webp.

this is my code use multifilereader:

https://github.com/godcong/go-ipfs-restapi/blob/0529bee4f0363d68a96c296862436bc3bc477b29/add.go#L142

and now, i only can split the all path to get the name use (filepath.Split) from http://127.0.0.1:5001/api/v0/add result .

[Stebalien]

@godcong could you give us the precise steps to reproduce this? It looks like we're failing to convert some paths here.

@djdv could you work with @godcong on this?

[godcong]

my system is windows 10.

i used the AddDir api with https://github.com/ipfs/go-ipfs-api and changed the output to this array:

// Object ...
type Object struct {
	Hash string
	Name string
	Size uint64
}

now i forked https://github.com/ipfs/go-ipfs-api and changes some.

this is the result decode area:
https://github.com/godcong/go-ipfs-restapi/blob/master/add.go#L172

i must split to get filename in json unmashal:
see https://github.com/godcong/go-ipfs-restapi/blob/master/add.go#L23
if not do this it will result a path like D:\video\H/p2526321708.webp for me.

[djdv]

@godcong
I'm interested in where the source string is originating and what code-path it's taking.*
For go-ipfs the translation happens around here:
https://github.com/ipfs/go-ipfs-cmds/blob/2e550a162686e63bdccc537fc4726e3239f2d598/cli/parse.go#L292
where we translate command line arguments into api compatible paths.

As well as in the files api in a few places to iterate over the next file in a list

go-ipfs-files/serialfile.go

Line 88 in c68472a

filePath := filepath.ToSlash(filepath.Join(it.path, stat.Name()))

It may be that we need to do something simillar here:
https://github.com/ipfs/go-ipfs-api/blob/96503ab85cc47f2b0e7c8e1bb3346d6937dd55a0/add.go#L93

Edit: * https://github.com/godcong/go-ipfs-restapi/blob/0529bee4f0363d68a96c296862436bc3bc477b29/add.go#L142 is returning 404

[Stebalien]

@godcong could you give us a small program that reproduces this on your machine?

[godcong]

@djdv
i renamed old project to
https://github.com/godcong/go-ipfs-restapi-bak/blob/master/add.go#L142

because i think most of the actions are the same as go-ipfs-api.

@Stebalien
yes,i add a branch issues16 and a main.go in
https://github.com/godcong/go-ipfs-restapi/tree/issues16/issues/issues16

you can change to any path for add files with AddDir:
https://github.com/godcong/go-ipfs-restapi/blob/0a31b2aaec0364b8690123512ed6beccb0826012/issues/issues16/main.go#L10

objects, e := s.AddDir("D:\\workspace\\goproject\\go-ipfs-restapi\\issues\\issues16\\")

when i use go run main.go the output result is:

&{Hash:QmatoEW5Xu8ndYKDeW9h3DcA1oeU7iUHWS6sZ1hYwztf4K Name:D:\workspace\goproject\go-ipfs-restapi\issues\issues16\/main.go Size:321}&{Hash:QmW8hBLAUpvfhFad9L8faSqz6MVyEcz9WTDiDyANLCgQnG Name:D:\workspace\goproject\go-ipfs-restapi\issues\issues16\/test.jpg Size:57804}&{Hash:QmVUo6UeEWpcQCroqRY1uw47eAmZKEFdPJA
r8dh1kpJpx9 Name:D:\workspace\goproject\go-ipfs-restapi\issues\issues16\ Size:58231}

in this branch, i only changed
https://github.com/godcong/go-ipfs-restapi/blob/0a31b2aaec0364b8690123512ed6beccb0826012/add.go#L36
for test.

[Stebalien]

Ah. Got it. Could you test against ipfs/go-ipfs-api#178? This looks like a bug in the API.

[godcong]

I have tried to changed path to filepath.

ipfs ls $hash

this will result nothing on version 0.4.19/0.4.18, if you add files with \.

ipfs get $hash

will get nothing on committed hash.

i'm not sure if it was changed now.
I will try to test this submit as soon as possible on version 0.4.20

Please ignore the above paragraph！
This is caused by the fact that I changed a wrong location.

[Stebalien]

I'm having trouble understanding your comment.

Unfortunately, this change will only affect newly added files. Files added before this change will have \ in their file-names and, unfortunately, the only solution is to re-add those files.