New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/circuit relay #6
Conversation
|
@dryajov just saw that the table on -- ipfs/js-ipfs#1063 -- has been updated to: This is excellent! Do we have tests in place for all of those? |
|
Yep, all tests are implemented, currently working to get all CIs green. |
929889e
to
3ba1527
Compare
c65276f
to
d1af049
Compare
|
documenting CI issues here - #11 |
|
|
.aegir.js
Outdated
| browserDisconnectTimeout: 500 * 1000, | ||
| browserNoActivityTimeout: 500 * 1000, | ||
| browserDisconnectTimeout: 5000 * 1000, | ||
| browserNoActivityTimeout: 5000 * 1000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do the tests take so much time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure yet - investigating.
226341e
to
eea5a0f
Compare
|
There are two skipped tests right now I'll add issues to track the skipped tests. |
|
Here is the issue documenting |
|
@diasdavid I don't think that adding a flag ( I'm going to skip opening another issue with an adhoc solution and propose that we figure out service discovery soonish. Went ahead and added an issue to track the connect timeouts - #17 |
|
Update. The issue documented in #16 has been troubleshooted and resolved in go. We should now how %100 of our interop tests covered. |
Test it :) |
|
@dryajov I mean, you should be able to pull a custom version of go-ipfs -- https://github.com/ipfs/interop#test-with-a-non-yet-released-version-of-go-ipfs -- and verify that indeed all tests pass. |
|
We can also create a branch in Here is the output from a run using the circuit fix. Tests> interop-ipfs@0.0.0 test /Users/dryajov/personal/projects/ipfs/ipfs/interop > cross-env IPFS_REUSEPORT=false aegir test -t node -t browser --no-corsTest Node.js �[0m�[0m �[0m repo�[0m �[0m exchange files�[0m �[0m kad-dht�[0m �[0m pubsub�[0m �[92m �[0m�[32m 71 passing�[0m�[90m (3m)�[0m Test Browser kad-dht circuit 40 passing (6m) |
|
@diasdavid now that ipfs/js-ipfs#1063 is remeged, any reason to keep this open? Specially since we have #16 to track the remaining test? |
|
@dryajov js-ipfs needs to be released first. |
|
Merging these and leaving them skipped to avoid future merge conflicts. Waiting on go-ipfs 0.4.15! |

No description provided.