Skip to content

Conversation

coryschwartz
Copy link

No description provided.

@welcome
Copy link

welcome bot commented Sep 2, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
  • Your contribution itself is clear (grammar and spelling checked, any code blocks checked and commented) and in its best form. Follow the docs contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
  • The PR gets reviews, discussed and approvals as needed.
  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@netlify
Copy link

netlify bot commented Sep 2, 2022

Deploy Preview for neon-choux-85b010 ready!

Name Link
🔨 Latest commit 4c8e9c7
🔍 Latest deploy log https://app.netlify.com/sites/neon-choux-85b010/deploys/6320358ed1e58d00094d88e1
😎 Deploy Preview https://deploy-preview-1270--neon-choux-85b010.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@salmad3 salmad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution @coryschwartz, added some suggestions

@salmad3 salmad3 added the need/author-input Needs input from the original author label Sep 3, 2022
@salmad3
Copy link
Contributor

salmad3 commented Sep 12, 2022

hi @coryschwartz, wondering if you'd had the chance to consider the suggestions.

Cory Schwartz and others added 3 commits September 13, 2022 00:31
Co-authored-by: Danny Salman <salman.danny03@hotmail.com>
Co-authored-by: Danny Salman <salman.danny03@hotmail.com>
Co-authored-by: Danny Salman <salman.danny03@hotmail.com>
@coryschwartz
Copy link
Author

Thanks. Those suggestions looked good. Thank you, @DannyS03 !

@salmad3 salmad3 removed the need/author-input Needs input from the original author label Sep 13, 2022
@salmad3
Copy link
Contributor

salmad3 commented Sep 13, 2022

thanks @coryschwartz!

@salmad3 salmad3 merged commit 87add9c into ipfs:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants