Skip to content

Conversation

ElPaisano
Copy link
Contributor

@welcome
Copy link

welcome bot commented Sep 14, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
  • Your contribution itself is clear (grammar and spelling checked, any code blocks checked and commented) and in its best form. Follow the docs contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
  • The PR gets reviews, discussed and approvals as needed.
  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@johnnymatthews
Copy link
Contributor

johnnymatthews commented Sep 14, 2022

There's a build error stopping this PR from merging:

2022-09-14T18:49:38.263Z: [vuepress] No matching page found for sidebar item "/project/contribute"

Looks like you need to remove the respective sidebar item. The file you need to update is /docs/.vuepress/config.js.

@ElPaisano
Copy link
Contributor Author

ElPaisano commented Sep 14, 2022

@johnnymatthews thanks for the review.

I think that fe34a24 should address this. Build looks like it succceeded.

Is there a way to preview fleek errors locally so that I can avoid pushing a broken build in the future? I tested the site locally before pushing using npm start and manually checking for errors on the local copy of the site. The npm logs didn't show any build errors

Copy link
Contributor

@TMoMoreau TMoMoreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Seems to be building fine now.

@TMoMoreau TMoMoreau merged commit 92f372e into ipfs:main Sep 14, 2022
@johnnymatthews
Copy link
Contributor

johnnymatthews commented Sep 15, 2022

Is there a way to preview fleek errors locally so that I can avoid pushing a broken build in the future? I tested the site locally before pushing using npm start and manually checking for errors on the local copy of the site. The npm logs didn't show any build errors - @ElPaisano

The errors that Fleek spits out are the same you should get when running npm run build NPM puts the built site into the public folder. If it doesn't build locally, then it shouldn't build in Fleek. It's the same the other way around (doesn't build in Fleek, then it shouldn't build locally).

Using npm run start is tricky, since it uses the dev version of the Hugo server -- which sometimes ignores certain errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants