Could we use vanilla JavaScript in the 101 example?

[davidgilbertson]

Type: Enhancement

Severity: Very Low

Description: Use vanilla JavaScript in the 101 example

Would you accept a PR that changes the 101 example to not require a third party npm package (the async package)?

For me, the async package syntax was just another thing I needed to wrap my mind around, when native async/await is so much prettier.

Existing

series([
  (cb) => node.on('ready', cb),
  (cb) => node.version((err, version) => {
    if (err) { return cb(err) }
    console.log('Version:', version.version)
    cb()
  }),
  (cb) => node.files.add({
    path: 'hello.txt',
    content: Buffer.from('Hello World 101')
  }, (err, filesAdded) => {
    if (err) { return cb(err) }

    console.log('\nAdded file:', filesAdded[0].path, filesAdded[0].hash)
    fileMultihash = filesAdded[0].hash
    cb()
  }),
  (cb) => node.files.cat(fileMultihash, (err, data) => {
    if (err) { return cb(err) }

    console.log('\nFile content:')
    process.stdout.write(data)
  })
])

Proposed

node.on('ready', async () => {
  const version = await node.version();

  console.log('Version:', version.version);

  const filesAdded = await node.files.add({
    path: 'hello.txt',
    content: Buffer.from('Hello World 101'),
  });

  console.log('Added file:', filesAdded[0].path, filesAdded[0].hash);

  const fileBuffer = await node.files.cat(filesAdded[0].hash);

  console.log('Added file contents:', fileBuffer.toString());
});

(I think it's OK to leave error handling out of a 101)

Or was this left out because the required Node version is 6 but async/await wasn't supported until 7?

[alanshaw]

Absolutely @davidgilbertson PR away!

[achingbrain]

FWIW the officially supported node versions are Current and Active LTS (v10 and v8 at the time of writing): https://github.com/ipfs/community/blob/master/js-code-guidelines.md#supported-versions

[davidgilbertson]

Ah interesting. Should I update the docs here: https://github.com/ipfs/js-ipfs#npm while I'm making the above change? It says npm 3 and node 6.

[achingbrain]

That'd be helpful - maybe just link to the guidelines though, that way we don't need to update the supported versions in multiple places.