Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Add pre-push lint? #1705

@jacobheun

Description

@jacobheun

Currently we don't do any pre-push behaviors in js-ipfs. Testing makes sense not to do because it takes way too long for everyone to have to run that locally. Linting is relatively quick (around 7 seconds for me locally).

While 7 seconds is annoying on a push, having this go to ci and doing an npm install on all agents before it lints is expensive if linting is going to fail, and is worth the time imo.

I think all warnings should be fixed before doing this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P4Very low priorityexp/noviceSomeone with a little familiarity can pick uphelp wantedSeeking public contribution on this issuestatus/readyReady to be worked

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions