This repository was archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Broken terminal output with API and Gateway on ipv6 #1853
Copy link
Copy link
Closed
Labels
P2Medium: Good to have, but can wait until someone steps upMedium: Good to have, but can wait until someone steps upexp/noviceSomeone with a little familiarity can pick upSomeone with a little familiarity can pick uphelp wantedSeeking public contribution on this issueSeeking public contribution on this issuekind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)
Description
Setting API
and Gateway
to listen on /ip6/
multiaddr..
"Addresses": {
"Swarm": [
"/ip4/0.0.0.0/tcp/4002",
"/ip4/127.0.0.1/tcp/4003/ws"
],
"API": "/ip6/::1/tcp/5002",
"Gateway": "/ip6/::1/tcp/9090"
},
works 👍
..but the terminal output is broken:
$ jsipfs daemon
[...]
API listening on /ip4//tcp/
Gateway (read only) listening on /ip4//tcp/
Web UI available at http://::1:5002/webui
Daemon is ready
Expected output:
API listening on /ip6/::1/tcp/5002
Gateway (read only) listening on /ip6/::1/tcp/9090
Web UI available at http://[::1]:5002/webui
ps. some quick notes from brief eyeballing:
apiMultiaddr
is set here but does not seem to be used for anythinguri-to-multiaddr
should be a good replacement foruriToMultiaddr
insrc/http/index.js
- it may be worth thinking if we want to fix it now, or after
hapi
situation is resolved (needs to be upgraded or migrated away to something else)
Metadata
Metadata
Assignees
Labels
P2Medium: Good to have, but can wait until someone steps upMedium: Good to have, but can wait until someone steps upexp/noviceSomeone with a little familiarity can pick upSomeone with a little familiarity can pick uphelp wantedSeeking public contribution on this issueSeeking public contribution on this issuekind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)