Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Conversation

hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Oct 29, 2018

This PR removes eslint config from webpack example to solve the missing esling-config-react when running aegir lint. This is one way to go.

Another option is to stop linting examples with aegir, and have them setup specific eslint configs.

Please give feedback about these two options and which one we should adopt.

Related:
https://github.com/ipfs/aegir/pull/293/files
#1665 (comment)

@ghost ghost assigned hugomrdias Oct 29, 2018
@ghost ghost added the status/in-progress In progress label Oct 29, 2018
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should go with this approach, instead of adding the eslint-plugin-react with all the aegir projects.

Moreover, Aegir should support custom configs according to the projects needs.

@hugomrdias
Copy link
Member Author

There's already a this PR ipfs/aegir#250 about custom eslint configs support

Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should stop linting the examples folder as part of the build for js-ipfs. The examples should have their own linting setup - they are essentially separate projects and we shouldn't let their dependencies leak into dependencies for js-ipfs.

They're going to need different linting rules because...react....so we can't really expect them to conform to linting for js-ipfs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants