This repository was archived by the owner on Feb 12, 2024. It is now read-only.
fix: remove example eslint config #1678
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes eslint config from webpack example to solve the missing esling-config-react when running
aegir lint
. This is one way to go.Another option is to stop linting examples with aegir, and have them setup specific eslint configs.
Please give feedback about these two options and which one we should adopt.
Related:
https://github.com/ipfs/aegir/pull/293/files
#1665 (comment)