fix: preload addreses with trailing slash

[lidel]

This PR:

• moves path utils to upstream utils
• closes Https address adds incorrectly to preload addreses #2333

[alanshaw]

@lidel multiaddr already deals with this issue:

multiaddr('/dns4/ipfs.io/tcp/3456/https/').toString()
// outputs: /dns4/ipfs.io/tcp/3456/https

The real issue is that we want to assume "http" when converting a multiaddr to a URI but multiaddr-to-uri does not.

I think it's a reasonable assumption and I reckon we can save ourselves a bunch of trouble and boilerplate by pushing this behaviour into multiaddr-to-uri (with a configuration option to disable it).

I think we should send a PR to multiaddr-to-uri to assume http:// if /http(s) is not explicit in the multiaddr and add a configuration option to disable it. This would solve our trailing slash problem and make it easier to use multiaddr-to-uri due to less boilerplate appending /http for 99.9% of users.

So something like the following would work:

toUri('/dns4/ipfs.io/tcp/3456')
// outputs: http://ipfs.io:3456

toUri('/dns4/ipfs.io/tcp/3456/https/')
// outputs: https://ipfs.io:3456

toUri('/dns4/ipfs.io/tcp/3456', { assumeHttp: false })
// outputs: tcp://ipfs.io:3456

What do you think?

[lidel]

Makes sense. Will open PR shortly.

[alanshaw]

I'm going to close this PR. Please open a new one that removes the endsWith('/http') boilerplate and updates the multiaddr-to-uri dependency when the time comes. 😘

[lidel]

Continued in #2377