This repository was archived by the owner on Feb 12, 2024. It is now read-only.
tests: update ipfsd-ctl #2368
Merged
tests: update ipfsd-ctl #2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've no clue why the tests fail on Windows, has anyone seen something like this before? I also don't know why the bundle size is an issue, it seems fine locally (@hugomrdias do you perhaps know?). |
alanshaw
suggested changes
Aug 21, 2019
This new version of ipfsd-ctl is using async/await instead of callbacks. Hence some rather mechanical changes are needed for tests.
alanshaw
approved these changes
Aug 29, 2019
|
🎉 thanks @achingbrain for fixing this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new version of ipfsd-ctl is using async/await instead of callbacks.
Hence some rather mechanical changes are needed for tests.
I've tried to keep this change as focused as possible. The tests could
well need some more async/await love, but I didn't want to mix concerns.