This repository was archived by the owner on Feb 12, 2024. It is now read-only.
chore: allow externals to fail #2736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
approved these changes
Feb 3, 2020
We need to publish an rc for people to use to refactor their code to use the new API. The `aegir` release commands require the `last-successful` build to have run in order to update the last known good build branch. That build will not run until the external builds pass but we can't make them pass until they can be refactored to use the new API for which we need an rc. The change to the `.travis.yml` in this PR allows the overall build to pass even though the external module builds are faiilng.
achingbrain
force-pushed
the
allow-externals-to-fail
branch
from
dca6809 to
93e298a
Compare
alanshaw
approved these changes
Feb 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to publish an rc for people to use to refactor their code to use the new API.
The
aegirrelease commands require thelast-successfulbuild to have run in order to update the last known good build branch.That build will not run until the external builds pass but we can't make them pass until they can be refactored to use the new API for which we need an rc.
The change to the
.travis.ymlin this PR allows the overall build to pass even though the external module builds are faiilng.Depends on: