Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Conversation

achingbrain
Copy link
Member

Should make PR builds much faster. Might have to be a bit smarter about coverage reports over time though.

@achingbrain achingbrain requested a review from hugomrdias March 11, 2020 09:47
@hugomrdias
Copy link
Member

Can you explain further this change, maybe an example.
Doesn't lerna run tests only in packages with changed files?

@achingbrain
Copy link
Member Author

achingbrain commented Mar 11, 2020

Doesn't lerna run tests only in packages with changed files?

Not by default - unlike releases (which use lerna updated) you have to specify --since [ref] for that.

For example #2914 only changed an example, which nothing depends on so only the tests for the example should have run, yet in the build for that PR it ran everything - interop, interface tests, the lot.

Interface & interop tests are defined in the ipfs and ipfs-http-client packages, which were not changed so should not have run.

When specifying --since to lerna run it does still work out the dependency graph and run scripts in packages that haven't changed but are dependant on ones that have.

@achingbrain achingbrain merged commit ff272f1 into master Mar 11, 2020
@achingbrain achingbrain deleted the chore/only-test-since-master branch March 11, 2020 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants