Skip to content

Conversation

juhasch
Copy link
Member

@juhasch juhasch commented Sep 4, 2016

  • Simplify docs generation (only make html required)
  • Prepare for readthedocs
  • Remove extensions.rst. Will be built by md2rst.py

docs/make.bat Outdated
del /q /s %BUILDDIR%\*
for /d %%i in (source\*) do rmdir /q /s %%i

del /q /s source\extensions.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we maybe use the full package name of jupyter_contrib_nbextensions here too? Or at least specify nbextensions over extensions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the name matters ?
It is just a filename that is being generated and contains the list of notebook extensions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't matter, in the sense that it'll still work fine regardless. But, it's just slightly less surprising/confusing to keep all the names consistent

@juhasch juhasch merged commit 700571d into ipython-contrib:master Sep 6, 2016
@juhasch
Copy link
Member Author

juhasch commented Sep 6, 2016

@jcb91 It seems I have hit a bug with RTD now:

Error: ERROR: placeholder '/opt/conda/envs/_build_placehold_placehold_placehold_placehold_placehold_placeho' too short in: openssl-1.0.2h-2

See readthedocs/readthedocs.org#1902

Oh well...

@juhasch juhasch deleted the doc_generation branch September 6, 2016 19:51
@jcb91
Copy link
Member

jcb91 commented Sep 7, 2016

@juhasch apologies for the delayed reply. I've not built anything on rtd before, so I'm not really in a position to offer any advice, I'm afraid. Perhaps we could do this not through conda? Or wait for the bugfix 😄

@juhasch
Copy link
Member Author

juhasch commented Sep 8, 2016

Sure, I will investigate further. I guess your suggestion not to use conda for now is what I will try next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants