Add Tab key to list of keys that scroll down the paging widget. #835

punchagan · Oct 3, 2011

When the RichIPythonWidget is embedded in another app, hitting a in the paging widget (during long completion) switches the focus to another Widget in the app where the IPython widget is embedded. This commit fixes that behaviour, by making the TAB key also scroll a page in the paging widget.

fperez · Oct 8, 2011

Unfortunately the PR doesn't currently merge, you'll need to rebase the commit against master before we can review it. I'm afraid there's been enough recent code churn in master that this fell behind, sorry about that. Ping us if you need a hand with the rebase; just do a forced push to your branch when done.

We'll be happy to take a look then. Thanks!

punchagan · Oct 9, 2011

Ok, I force pushed a change. Thanks!

epatters · Oct 11, 2011

Great, thanks for the fix.

punchagan Add Tab key to list of keys that scroll down the paging widget. 6bdbf8e

epatters merged commit 7883c91 into ipython:master from unknown repository Oct 11, 2011

ellisonbg referenced this pull request from a commit Jan 11, 2012

Commit has since been removed from the repository and is no longer available.

@@ @@ -1265,7 +1265,8 @@ def _event_filter_page_keypress(self, event): @@
                  self.layout().setCurrentWidget(self._control)
              return True
--        elif key in (QtCore.Qt.Key_Enter, QtCore.Qt.Key_Return):
++        elif key in (QtCore.Qt.Key_Enter, QtCore.Qt.Key_Return,
++                     QtCore.Qt.Key_Tab):
              new_event = QtGui.QKeyEvent(QtCore.QEvent.KeyPress,
                                          QtCore.Qt.Key_PageDown,
                                          QtCore.Qt.NoModifier)

ipython/ipython

HTTPS clone URL

Subversion checkout URL

Add Tab key to list of keys that scroll down the paging widget. #835

Labels

Milestone

Assignee

3 participants