Skip to content

Add Tab key to list of keys that scroll down the paging widget. #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2011
Merged

Add Tab key to list of keys that scroll down the paging widget. #835

merged 1 commit into from
Oct 11, 2011

Conversation

punchagan
Copy link
Contributor

When the RichIPythonWidget is embedded in another app, hitting a in the paging widget (during long completion) switches the focus to another Widget in the app where the IPython widget is embedded. This commit fixes that behaviour, by making the TAB key also scroll a page in the paging widget.

@fperez
Copy link
Member

fperez commented Oct 8, 2011

Unfortunately the PR doesn't currently merge, you'll need to rebase the commit against master before we can review it. I'm afraid there's been enough recent code churn in master that this fell behind, sorry about that. Ping us if you need a hand with the rebase; just do a forced push to your branch when done.

We'll be happy to take a look then. Thanks!

@punchagan
Copy link
Contributor Author

Ok, I force pushed a change. Thanks!

@epatters
Copy link
Contributor

Great, thanks for the fix.

epatters added a commit that referenced this pull request Oct 11, 2011
Add Tab key to list of keys that scroll down the paging widget.
@epatters epatters merged commit 7883c91 into ipython:master Oct 11, 2011
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Add Tab key to list of keys that scroll down the paging widget.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants