Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add Tab key to list of keys that scroll down the paging widget. #835
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
fperez
Oct 8, 2011
Member
Unfortunately the PR doesn't currently merge, you'll need to rebase the commit against master before we can review it. I'm afraid there's been enough recent code churn in master that this fell behind, sorry about that. Ping us if you need a hand with the rebase; just do a forced push to your branch when done.
We'll be happy to take a look then. Thanks!
|
Unfortunately the PR doesn't currently merge, you'll need to rebase the commit against master before we can review it. I'm afraid there's been enough recent code churn in master that this fell behind, sorry about that. Ping us if you need a hand with the rebase; just do a forced push to your branch when done. We'll be happy to take a look then. Thanks! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Ok, I force pushed a change. Thanks! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Great, thanks for the fix. |
added a commit
that referenced
this pull request
Oct 11, 2011
epatters
merged commit 7883c91
into
ipython:master
Oct 11, 2011
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
punchagan commentedOct 3, 2011
When the RichIPythonWidget is embedded in another app, hitting a in the paging widget (during long completion) switches the focus to another Widget in the app where the IPython widget is embedded. This commit fixes that behaviour, by making the TAB key also scroll a page in the paging widget.