3 participants
punchagan
commented
Owner
fperez
commented
Unfortunately the PR doesn't currently merge, you'll need to rebase the commit against master before we can review it. I'm afraid there's been enough recent code churn in master that this fell behind, sorry about that. Ping us if you need a hand with the rebase; just do a forced push to your branch when done.
We'll be happy to take a look then. Thanks!
punchagan
commented
Ok, I force pushed a change. Thanks!
Collaborator
epatters
commented
Great, thanks for the fix.
epatters
closed this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This page is out of date. Refresh to see the latest.
Showing 1 changed file with 2 additions and 1 deletion. Show diff stats
@@ -1265,7 +1265,8 @@ def _event_filter_page_keypress(self, event): |
||
| 1265 | 1265 |
self.layout().setCurrentWidget(self._control) |
| 1266 | 1266 |
return True |
| 1267 | 1267 |
|
| 1268 |
- elif key in (QtCore.Qt.Key_Enter, QtCore.Qt.Key_Return): |
|
| 1268 |
+ elif key in (QtCore.Qt.Key_Enter, QtCore.Qt.Key_Return, |
|
| 1269 |
+ QtCore.Qt.Key_Tab): |
|
| 1269 | 1270 |
new_event = QtGui.QKeyEvent(QtCore.QEvent.KeyPress, |
| 1270 | 1271 |
QtCore.Qt.Key_PageDown, |
| 1271 | 1272 |
QtCore.Qt.NoModifier) |
Tip: You can add notes to lines in a file. Hover to the left of a line to make a note
When the RichIPythonWidget is embedded in another app, hitting a in the paging widget (during long completion) switches the focus to another Widget in the app where the IPython widget is embedded. This commit fixes that behaviour, by making the TAB key also scroll a page in the paging widget.