Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add Tab key to list of keys that scroll down the paging widget. #835

Merged
merged 1 commit into from

3 participants

Puneeth Chaganti Fernando Perez Evan Patterson
Puneeth Chaganti

When the RichIPythonWidget is embedded in another app, hitting a in the paging widget (during long completion) switches the focus to another Widget in the app where the IPython widget is embedded. This commit fixes that behaviour, by making the TAB key also scroll a page in the paging widget.

Fernando Perez
Owner

Unfortunately the PR doesn't currently merge, you'll need to rebase the commit against master before we can review it. I'm afraid there's been enough recent code churn in master that this fell behind, sorry about that. Ping us if you need a hand with the rebase; just do a forced push to your branch when done.

We'll be happy to take a look then. Thanks!

Puneeth Chaganti

Ok, I force pushed a change. Thanks!

Evan Patterson
Collaborator

Great, thanks for the fix.

Evan Patterson epatters merged commit 7883c91 into from
Brian E. Granger ellisonbg referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +2 −1  IPython/frontend/qt/console/console_widget.py
3  IPython/frontend/qt/console/console_widget.py
View
@@ -1265,7 +1265,8 @@ def _event_filter_page_keypress(self, event):
self.layout().setCurrentWidget(self._control)
return True
- elif key in (QtCore.Qt.Key_Enter, QtCore.Qt.Key_Return):
+ elif key in (QtCore.Qt.Key_Enter, QtCore.Qt.Key_Return,
+ QtCore.Qt.Key_Tab):
new_event = QtGui.QKeyEvent(QtCore.QEvent.KeyPress,
QtCore.Qt.Key_PageDown,
QtCore.Qt.NoModifier)
Something went wrong with that request. Please try again.