Add Tab key to list of keys that scroll down the paging widget. #835

Merged
merged 1 commit into from Oct 11, 2011

Conversation

Projects
None yet
3 participants
@punchagan
Contributor

punchagan commented Oct 3, 2011

When the RichIPythonWidget is embedded in another app, hitting a in the paging widget (during long completion) switches the focus to another Widget in the app where the IPython widget is embedded. This commit fixes that behaviour, by making the TAB key also scroll a page in the paging widget.

@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Oct 8, 2011

Member

Unfortunately the PR doesn't currently merge, you'll need to rebase the commit against master before we can review it. I'm afraid there's been enough recent code churn in master that this fell behind, sorry about that. Ping us if you need a hand with the rebase; just do a forced push to your branch when done.

We'll be happy to take a look then. Thanks!

Member

fperez commented Oct 8, 2011

Unfortunately the PR doesn't currently merge, you'll need to rebase the commit against master before we can review it. I'm afraid there's been enough recent code churn in master that this fell behind, sorry about that. Ping us if you need a hand with the rebase; just do a forced push to your branch when done.

We'll be happy to take a look then. Thanks!

@punchagan

This comment has been minimized.

Show comment
Hide comment
@punchagan

punchagan Oct 9, 2011

Contributor

Ok, I force pushed a change. Thanks!

Contributor

punchagan commented Oct 9, 2011

Ok, I force pushed a change. Thanks!

@epatters

This comment has been minimized.

Show comment
Hide comment
@epatters

epatters Oct 11, 2011

Contributor

Great, thanks for the fix.

Contributor

epatters commented Oct 11, 2011

Great, thanks for the fix.

epatters added a commit that referenced this pull request Oct 11, 2011

Merge pull request #835 from punchagan/tab_pagedown
Add Tab key to list of keys that scroll down the paging widget.

@epatters epatters merged commit 7883c91 into ipython:master Oct 11, 2011

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #835 from punchagan/tab_pagedown
Add Tab key to list of keys that scroll down the paging widget.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment