Skip to content
This repository

Add Tab key to list of keys that scroll down the paging widget. #835

Merged
merged 1 commit into from over 2 years ago

3 participants

Puneeth Chaganti Fernando Perez Evan Patterson
Puneeth Chaganti

When the RichIPythonWidget is embedded in another app, hitting a in the paging widget (during long completion) switches the focus to another Widget in the app where the IPython widget is embedded. This commit fixes that behaviour, by making the TAB key also scroll a page in the paging widget.

Fernando Perez
Owner

Unfortunately the PR doesn't currently merge, you'll need to rebase the commit against master before we can review it. I'm afraid there's been enough recent code churn in master that this fell behind, sorry about that. Ping us if you need a hand with the rebase; just do a forced push to your branch when done.

We'll be happy to take a look then. Thanks!

Puneeth Chaganti

Ok, I force pushed a change. Thanks!

Evan Patterson
Collaborator

Great, thanks for the fix.

Evan Patterson epatters merged commit 7883c91 into from
Evan Patterson epatters closed this
Brian E. Granger ellisonbg referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Oct 09, 2011
Puneeth Chaganti Add Tab key to list of keys that scroll down the paging widget. 6bdbf8e
This page is out of date. Refresh to see the latest.
3  IPython/frontend/qt/console/console_widget.py
@@ -1265,7 +1265,8 @@ def _event_filter_page_keypress(self, event):
1265 1265
                 self.layout().setCurrentWidget(self._control)
1266 1266
             return True
1267 1267
 
1268  
-        elif key in (QtCore.Qt.Key_Enter, QtCore.Qt.Key_Return):
  1268
+        elif key in (QtCore.Qt.Key_Enter, QtCore.Qt.Key_Return,
  1269
+                     QtCore.Qt.Key_Tab):
1269 1270
             new_event = QtGui.QKeyEvent(QtCore.QEvent.KeyPress,
1270 1271
                                         QtCore.Qt.Key_PageDown,
1271 1272
                                         QtCore.Qt.NoModifier)
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.