Add CommManager.comms shim #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @jasongrout |
| @@ -58,9 +59,10 @@ namespace shims { | |||
| * comm is made. Signature of f(comm, msg). | |||
| */ | |||
| register_target (target_name, f) { | |||
| var handle = this.jsServicesKernel.registerCommTarget(target_name, function(jsServicesComm, msg) { | |||
| var handle = this.jsServicesKernel.registerCommTarget(target_name, _.bind(function(jsServicesComm, msg) { | |||
There was a problem hiding this comment.
You can use an arrow function here to automatically bind this:
(jsServicesComm, msg) => {
There was a problem hiding this comment.
Thanks, will do.
|
@jasongrout I made the change you suggested. Do you have any other objections? Otherwise this is ready to merge I think. |
github-actions
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current jupyter-js-services shim for the CommManager, which gets used by project's like the dashboard_server does not mirror the API of the real CommManager completely, which is generally no problem but I was hoping to at least expose a means to look up existing comms. bokeh 0.12.2 will use this part of the comm_manager API to register an on_msg callback on an existing Comm. In future bokeh will probably correctly set up a notebook extension and/or display plots as a widget so this should no longer be needed but for the time being it would be great if we could expose the
commson the shim. Tested with bokeh 0.12.2rc2 and the current dashboard_server master.