Skip to content

Conversation

zirain
Copy link
Member

@zirain zirain commented Jul 28, 2023

@zirain zirain requested a review from a team as a code owner July 28, 2023 03:56
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2023
@zirain zirain added release-notes-none Indicates a PR that does not require release notes. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2023
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2023
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a release note telling users what to do (move to otel, I assume).

otherwise LGTM

Copy link
Contributor

@costinm costinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - should we add notes to the other providers and indicate the intent to deprecate and warn users off ? I assume there are no objections to adopting otel and using
otel collectors as integration point with vendor protocols.

Also not sure if deprecate + hide from docs is the correct path - normally we want users to see the field and deprecation warning in the generated docs.

@zirain
Copy link
Member Author

zirain commented Jul 31, 2023

Looks good - should we add notes to the other providers and indicate the intent to deprecate and warn users off ? I assume there are no objections to adopting otel and using otel collectors as integration point with vendor protocols.

Also not sure if deprecate + hide from docs is the correct path - normally we want users to see the field and deprecation warning in the generated docs.

Plan to add warning notes in istioctl analysis

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 31, 2023
@zirain zirain requested a review from howardjohn July 31, 2023 03:13
@zirain zirain removed the release-notes-none Indicates a PR that does not require release notes. label Jul 31, 2023
@istio-testing istio-testing merged commit 9d67259 into istio:master Jul 31, 2023
@zirain zirain deleted the sunset-opencensus branch July 31, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants