Skip to content

docs: remove per-version API tabs #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

howardjohn
Copy link
Member

Fixes #2994

@howardjohn howardjohn requested a review from a team as a code owner February 27, 2024 18:32
@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Feb 27, 2024
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-testing istio-testing added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 27, 2024
Copy link
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericvn
Copy link

ericvn commented Mar 5, 2024

One thing I want to investigate, which is likely a nit, is why the .html file is under an older version in the source tree (ex: networking/v1alpha3/service_entry.pb.html as opposed to being in v1beta1). I suspect we have logic to only create one in the older version (at least in the case of dupes). Overall, this doesn't make a change in what is shown in istio.io, it's just where the file is placed here.

@howardjohn
Copy link
Member Author

One thing I want to investigate, which is likely a nit, is why the .html file is under an older version in the source tree (ex: networking/v1alpha3/service_entry.pb.html as opposed to being in v1beta1). I suspect we have logic to only create one in the older version (at least in the case of dupes). Overall, this doesn't make a change in what is shown in istio.io, it's just where the file is placed here.

v1beta1 ones have $mode: none to avoid generation to avoid duplicates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove API version tabs
5 participants