Skip to content

Conversation

zengyuxing007
Copy link
Contributor

@zengyuxing007 zengyuxing007 requested a review from a team as a code owner March 11, 2024 03:58
@istio-policy-bot
Copy link

😊 Welcome @zengyuxing007! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 11, 2024
@zengyuxing007 zengyuxing007 added the release-notes-none Indicates a PR that does not require release notes. label Mar 11, 2024
@zengyuxing007
Copy link
Contributor Author

/test release-notes

Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These LGTM as documentation in general, but not for ambient necessarily; that is seperate

@ericvn
Copy link

ericvn commented Mar 12, 2024

/test gencheck

1 similar comment
@ericvn
Copy link

ericvn commented Mar 12, 2024

/test gencheck

@istio-testing istio-testing merged commit c6ba867 into istio:master Mar 12, 2024
@@ -530,3 +530,66 @@ annotations:
hidden: true
resources:
- Any

- name: traffic.istio.io/includeOutboundIPRanges
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to highlight these annotations are used for ambient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants