Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions networking/v1alpha3/envoy_filter.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 11 additions & 10 deletions networking/v1alpha3/envoy_filter.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 10 additions & 9 deletions networking/v1alpha3/envoy_filter.proto
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import "google/protobuf/struct.proto";
// with each other.
//
// The following example for Kubernetes enables Envoy's Lua filter for all
// inbound calls arriving at service port 8080 of the reviews service pod with
// inbound HTTP calls arriving at service port 8080 of the reviews service pod with
// labels "app: reviews".
//
// ```yaml
Expand All @@ -51,6 +51,7 @@ import "google/protobuf/struct.proto";
// - listenerMatch:
// portNumber: 8080
// listenerType: SIDECAR_INBOUND # will match with the inbound listener for reviews:8080
// listenerProtocol: HTTP
// filterName: envoy.lua
// filterType: HTTP
// filterConfig:
Expand All @@ -68,9 +69,6 @@ message EnvoyFilter {
// example, the scope includes pods running in all reachable
// namespaces. Omitting the selector applies the filter to all proxies in
// the mesh.
// NOTE: There can be only one EnvoyFilter bound to a specific workload.
// The behavior is undefined if multiple EnvoyFilter configurations are
// specified for the same workload.
map<string, string> workload_labels = 1;

// Select a listener to add the filter to based on the match conditions.
Expand Down Expand Up @@ -116,11 +114,11 @@ message EnvoyFilter {
TCP = 2;
};

// Selects a class of listeners for the same protocol. If not
// specified, applies to listeners on all protocols. Use the protocol
// Selects a class of listeners for the same protocol. Use the protocol
// selection to select all HTTP listeners (includes HTTP2/gRPC/HTTPS
// where Envoy terminates TLS) or all TCP listeners (includes HTTPS
// passthrough using SNI).
// passthrough using SNI). When adding a HTTP filter, the listenerProtocol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// passthrough using SNI). When adding a HTTP filter, the listenerProtocol
// passthrough using SNI). When adding an HTTP filter, the listenerProtocol

// should be set to HTTP.
ListenerProtocol listener_protocol = 4;

// One or more IP addresses to which the listener is bound. If
Expand Down Expand Up @@ -155,8 +153,11 @@ message EnvoyFilter {

// Envoy filters to be added to a network or http filter chain.
message Filter {
// Filter will be added to the listener only if the match conditions are true.
// If not specified, the filters will be applied to all listeners.
// Filter will be added to the listener only if the match
// conditions are true. If not specified, the filters will be
// applied to all listeners where possible, potentially resulting
// in invalid configurations. It is recommended to specify the
// listener match criteria for all filter insertions.
ListenerMatch listener_match = 1;

// Insert position in the filter chain. Defaults to FIRST
Expand Down
3 changes: 1 addition & 2 deletions networking/v1alpha3/sidecar.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions networking/v1alpha3/sidecar.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions networking/v1alpha3/sidecar.proto
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,7 @@ option go_package = "istio.io/api/networking/v1alpha3";
message Sidecar {
// Criteria used to select the specific set of pods/VMs on which this
// sidecar configuration should be applied. If omitted, the sidecar
// configuration will be applied to all workloads in the same config
// namespace.
// configuration will be applied to all workloads in the same namespace.
WorkloadSelector workload_selector = 1;

// Ingress specifies the configuration of the sidecar for processing
Expand Down
6 changes: 3 additions & 3 deletions networking/v1alpha3/virtual_service.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions networking/v1alpha3/virtual_service.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions networking/v1alpha3/virtual_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -814,9 +814,9 @@ message TLSMatchAttributes {
// - match:
// - uri:
// exact: /v1/getProductRatings
// redirect:
// uri: /v1/bookRatings
// authority: newratings.default.svc.cluster.local
// redirect:
// uri: /v1/bookRatings
// authority: newratings.default.svc.cluster.local
// ...
// ```
message HTTPRedirect {
Expand Down