Skip to content

Conversation

rshriram
Copy link
Member

@rshriram rshriram commented Mar 19, 2019

Signed-off-by: Shriram Rajagopalan rshriram@gmail.com

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Mar 19, 2019
Signed-off-by: Shriram Rajagopalan <rshriram@gmail.com>
// selection to select all HTTP listeners (includes HTTP2/gRPC/HTTPS
// where Envoy terminates TLS) or all TCP listeners (includes HTTPS
// passthrough using SNI).
// passthrough using SNI). When adding a HTTP filter, the listenerProtocol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// passthrough using SNI). When adding a HTTP filter, the listenerProtocol
// passthrough using SNI). When adding an HTTP filter, the listenerProtocol

Copy link
Contributor

@frankbu frankbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@geeknoid geeknoid merged commit c1e0c86 into istio:release-1.1 Mar 19, 2019
istio-testing pushed a commit that referenced this pull request Mar 21, 2019
* Doc fixes.

* Add high-level overview and diagrams for MCP (#805)

* document MCP

* add additional note on NACK behavior

* add a note about ignoring stale nonces

* Add envoy metrics service configuration to ProxyConfig (#803)

* Add envoy metrics service configuration to ProxyConfig

Similar to the statsd sink config, this change is in preparation for adding support for the envoy metrics service API.

* Update proto.lock

* Reorder metrics_service_address just after statsd_udp_address

* Update comment in the authN API to match with 1.1 behavior (#808)

* Rename metrics_service_address to clarify that it is for Envoy's API (#809)

Since "metrics service" is so ambiguous, this change specifically denotes that the config is for Envoy's metrics service API. The comments also now link to detailed info about the metrics service API.

* Generate separate HTML page per proto under networking (#811)

* Generate separate pages for each networking proto

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* tweaks

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Fix interdoc references

* separate doc and go gen

* change dash to underscore

* fix

* more fixes

* makefile fix

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* remove bad target

* Revert "change dash to underscore"

This reverts commit 7fbced6.

* final update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Revert "Generate separate HTML page per proto under networking (#811)"

This reverts commit 5f14ead since it breaks the ability
to generate reference docs in istio.io

* Update to latest tools.

* Revert "Update to latest tools."

This reverts commit 231fadc which I accidentally pushed to the
wrong place.

* fix mcp update error diagram (#810)

* update istio/tools (#815)

* Revert "Revert "Generate separate HTML page per proto under networking (#811)"" (#818)

* Minor updates for building docker images. (#817)

* Add spell checking for docs. (#819)

* Add a bunch of words to the custom dictionary.

* Document exportTo restrictions (#820)

* Doc fixes. (#821)

* Proxy config: Add tls_certs_to_watch field (#824)

* Proxy config: Add tls_certs_to_watch field

* Address PR comment

* Revert "Proxy config: Add tls_certs_to_watch field (#824)" (#825)

This reverts commit e613e35.

* Update gateway and sidecar hosts doc (#826)

* Update gateway and sidecar hosts doc

* regen

* review comments

* Update API docs (service entry, gateway, sidecar) (#831)

* Update sidecar and gateway docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* gen docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update service entry

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* updates

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* add configurable dns refresh rate to mesh for strict dns cluster,  (#832)

* add configurable dns refresh rate to mesh for strict dns cluster, issue #12181

* add lock file

* Hosts are not ignored in ServiceEntry for HTTPs (#833)

* Hosts are not ignored in ServiceEntry for HTTPs

* Clarify

* Reword

* Generate protos

* Address code review comments

* Fix typo

* generate

* make mixer config marshal deterministic (#846)

Signed-off-by: Kuat Yessenov <kuat@google.com>

* Fix some doc errors. (#854)

This started out to just fix a bad link to unblock work on
istio.io, but I ended up fixing a bunch of typos/incorrect format
throughout.

* Fix two more broken links. (#856)

* Fix CRD examples for release-1.1 (#859)

* fix MeshNetworks demo (#841)

* fix MeshNetworks demo

* generate

* update

* last minute doc fixes (#865)

Signed-off-by: Shriram Rajagopalan <rshriram@gmail.com>

* Clarify comment for server_name field in Mixer oop auth config (#800)

* add mixerclient config to istio.io reference docs (#827)

* Envoyfilter docs fix (#867)

* Tweaks to get the mixer client config docs to be published. (#868)

* Change where the Mixer client docs are published.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants