Skip to content

Commit d39dbc8

Browse files
minor dns test fix (#33178)
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
1 parent eee5bee commit d39dbc8

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

pilot/pkg/dns/dns_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,8 +247,9 @@ func TestDNS(t *testing.T) {
247247
t.Errorf("upstream dns resolution for %s failed: %v", tt.host, res)
248248
}
249249
} else {
250-
if tt.expectResolutionFailure != res.Rcode {
251-
t.Errorf("expected resolution failure but it succeeded for %s: %v", tt.host, res)
250+
if tt.expectResolutionFailure > 0 && tt.expectResolutionFailure != res.Rcode {
251+
t.Errorf("expected resolution failure does not match with response code for %s: expected: %v, got: %v",
252+
tt.host, tt.expectResolutionFailure, res.Rcode)
252253
}
253254
if !equalsDNSrecords(res.Answer, tt.expected) {
254255
t.Log(res)

0 commit comments

Comments
 (0)