We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent eee5bee commit d39dbc8Copy full SHA for d39dbc8
pilot/pkg/dns/dns_test.go
@@ -247,8 +247,9 @@ func TestDNS(t *testing.T) {
247
t.Errorf("upstream dns resolution for %s failed: %v", tt.host, res)
248
}
249
} else {
250
- if tt.expectResolutionFailure != res.Rcode {
251
- t.Errorf("expected resolution failure but it succeeded for %s: %v", tt.host, res)
+ if tt.expectResolutionFailure > 0 && tt.expectResolutionFailure != res.Rcode {
+ t.Errorf("expected resolution failure does not match with response code for %s: expected: %v, got: %v",
252
+ tt.host, tt.expectResolutionFailure, res.Rcode)
253
254
if !equalsDNSrecords(res.Answer, tt.expected) {
255
t.Log(res)
0 commit comments