Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building scipy #129

Open
isuruf opened this issue Feb 21, 2019 · 7 comments
Open

Building scipy #129

isuruf opened this issue Feb 21, 2019 · 7 comments

Comments

@isuruf
Copy link
Owner

isuruf commented Feb 21, 2019

Status at https://ci.appveyor.com/project/conda-forge/scipy-feedstock/build/1.0.10/job/002sr96nxm5vpp10?fullLog=true

is 34 failed, 12047 passed, 1371 skipped, 577 deselected, 75 xfailed, 6 xpassed, 16 warnings in 397.47 seconds

Some of these are compiler errors and might have been fixed in flang upstream. This fork hasn't been updated since May 2018 and therefore has lots of conflicts.

cc @rgommers.

@rgommers
Copy link

Thanks @isuruf. Just missed this when opening gh-130. Most of those failures seem to be related to linalg; OpenBLAS was built with Flang there as well it looks like. Fixing those may not be trivial, but it's hard to tell.

I'm also thinking about sustainability. To continue on my comment in gh-130: this repo is for now a one person effort (after @xoviat has left us) so if Flang devs won't merge your PRs that's a potential issue. On the other hand; with mingw-w64 and Mingwpy the situation is quite similar. I think right now both are half-finished. Going from there to one maintained fork would be very nice. I don't think we can as a community maintain two solutions. Do you have any thoughts/preferences on this?

Cc @matthew-brett and @carlkl

@isuruf
Copy link
Owner Author

isuruf commented Feb 21, 2019

I think both flang and mingwpy are viable solutions. With flang, I think the expertise needed to maintain it is lower than mingwpy, so on the short term, it's easier to get flang working (except for a few compiler bugs)

On the long term though, we should go with the option that has the best chance of merging upstream and working with upstream. (This is needed much more for flang because we'll need upstream help on fixing bugs on the compiler that are not specific to windows as flang is not battle-tested) I don't think maintaining a fork indefinitely is going to be feasible. Maybe we should reach out to flang devs on their mailing list again to see what they think.

@carlkl
Copy link

carlkl commented Feb 21, 2019 via email

@rgommers
Copy link

On the long term though, we should go with the option that has the best chance of merging upstream and working with upstream.

Definitely agree with that

Maybe we should reach out to flang devs on their mailing list again to see what they think.

That would be a good idea. not sure about timing though - I don't have much spare time to offer at the moment (also, I don't know much about Fortran compiler internals, so not sure if I'd be very helpful anyway).

Personally I will keep going the mingw-w64 route.

Thanks Carl. I suspected as much:)

@isuruf
Copy link
Owner Author

isuruf commented May 24, 2019

Update: Some of my PRs for flang are getting attention upstream and I'm hopeful that we'll see windows support upstream soon. (Maybe at the end of the summer if I find time)

@matthew-brett
Copy link

@isuruf - any progress with Flang / Windows?

@isuruf
Copy link
Owner Author

isuruf commented Jun 29, 2019

flang-compiler/flang-driver#70 was merged. There are more under review https://github.com/flang-compiler/flang/pulls/isuruf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@matthew-brett @rgommers @isuruf @carlkl and others