tree: walk: operate on tree absolute root #1907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
suggested changes
Apr 20, 2019
efiop
suggested changes
Apr 22, 2019
tests/func/test_metrics.py
Outdated
Contributor
There was a problem hiding this comment.
But mfile is not even in metrics. Are you using it at all then?
Contributor
Author
There was a problem hiding this comment.
good point, at the beggining I didn't realize that this test sets up few metrics. There is no need for additional one. Also, there is no need to run any command, as we already have metrics on different branches.
efiop
reviewed
Apr 22, 2019
tests/func/test_metrics.py
Outdated
Contributor
There was a problem hiding this comment.
Looks like json part was left from copypasting? 🙂
Contributor
There was a problem hiding this comment.
Maybe use self.files instead? Those are set in setUp.
efiop
suggested changes
Apr 22, 2019
tests/func/test_metrics.py
Outdated
Contributor
There was a problem hiding this comment.
relpath will use os.getcwd by default, no need to specify it.
efiop
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you followed the guidelines in our
Contributing document?
Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
dvc.org documenting it or at
least opened an issue for it? If so, please add a link to it.
Fixes #1891