dvc metrics show: implement jsonpath-ng #1944
Conversation
| schema>=0.6.7 | ||
| paramiko>=2.4.1 | ||
| jsonpath-rw==1.4.0 | ||
| jsonpath-ng>=1.4.3 |
There was a problem hiding this comment.
Need to update setup.py as well.
|
@brbarkley Looks great! Thank you! There is one test failing in https://github.com/iterative/dvc/blob/master/tests/func/test_metrics.py#L295 . You just need to add |
updated setup.py updated test_metrics.py::assertMetricsHaveRelativePaths Fixes treeverse#1919
| ret = self.dvc.metrics.show( | ||
| "metric_json_ext", | ||
| typ="json", | ||
| xpath="$.metrics[?(@.deviation_mse<0.30) & (@.value_mse>0.4)]", |
There was a problem hiding this comment.
Wow, this is truly something 🙂 We should definitely document this. Could you please adjust --xpath description for json in https://dvc.org/doc/commands-reference/metrics-modify ?
efiop
left a comment
efiop
left a comment
There was a problem hiding this comment.
Looks great! The only thing left to do is to adjust the docs.
per [PR#1944](treeverse/dvc#1944 (comment))
|
Thank you! 🎉 |
See PR for docs #275. Obviously, ignore the PR that I accidentally submitted to my own fork 🙂 |
2 participants
Fixes #1919
Have you followed the guidelines in our
Contributing document?
Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
dvc.org documenting it or at
least opened an issue for it? If so, please add a link to it.