path info: replace path_info dicts with PathInfo class #1968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pared
force-pushed
the
1588
branch
6 times, most recently
from
20c47b4 to
83dc301
Compare
pared
changed the title
pared
force-pushed
the
1588
branch
4 times, most recently
from
018473c to
d844804
Compare
efiop
reviewed
May 10, 2019
efiop
reviewed
May 10, 2019
dvc/output/gs.py
Outdated
Contributor
There was a problem hiding this comment.
For the record: discussed introducing PathInfo(scheme, ...) function to help use common logic where possible.
efiop
reviewed
May 10, 2019
efiop
reviewed
May 10, 2019
efiop
reviewed
May 10, 2019
efiop
reviewed
May 10, 2019
efiop
reviewed
May 11, 2019
efiop
reviewed
May 11, 2019
efiop
reviewed
May 11, 2019
efiop
reviewed
May 11, 2019
efiop
reviewed
May 11, 2019
efiop
reviewed
May 11, 2019
efiop
reviewed
May 11, 2019
efiop
reviewed
May 11, 2019
dvc/remote/azure.py
Outdated
Contributor
There was a problem hiding this comment.
Seems like it should be in __init__, right?
pared
force-pushed
the
1588
branch
2 times, most recently
from
64ba0bc to
aa0876a
Compare
efiop
approved these changes
May 11, 2019
Contributor
efiop
left a comment
efiop
left a comment
There was a problem hiding this comment.
Looking good! Great start! We'll be able to work on top of this easily if we ever decide to go with moving some logic like remote.ospath to PathInfos. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you followed the guidelines in our
Contributing document?
Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
dvc.org documenting it or at
least opened an issue for it? If so, please add a link to it.
Fixes #1588