Skip to content

Conversation

@pared
Copy link
Contributor

@pared pared commented Dec 9, 2019

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • πŸ“– Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Related to #2896

@pared pared requested review from a user and efiop December 10, 2019 09:24
@efiop efiop added refactoring Factoring and re-factoring testing Related to the tests and the testing infrastructure labels Dec 11, 2019
@efiop efiop merged commit d2f4070 into treeverse:master Dec 11, 2019
@pared pared deleted the 2896_test_move branch December 17, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Factoring and re-factoring testing Related to the tests and the testing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants