Fix memory leak in Index.build_graph() #7198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@memoize()` memory lives as long as decorated function lives, which is permanent in this case. Since `self` is referenced as a memory key no `Index` will ever be freed. Changed to use `@cached_property` whose cache lives as long as the parent instance.
Suor
force-pushed
the
index-memory-leak
branch
from
59d8cfc to
65dff96
Compare
pared
approved these changes
Dec 27, 2021
Neilblaze
approved these changes
Jan 2, 2022
skshetry
approved these changes
Jan 3, 2022
Collaborator
|
btw @Suor, how did you figure/debug this out? This must have been tricky. |
Contributor
Author
|
I used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@memoize()memory lives as long as decorated function lives, which ispermanent in this case. Since
selfis referenced as a memory key noIndexwill ever be freed.Changed to use
@cached_propertywho's cache lives as long as theparent instance.
NOTE: This is an issue for Studio since we are parsing many commits in a long running process.