handle paths ending with sep in dvc.fs.path.Path.parts #7234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
efiop
approved these changes
Jan 6, 2022
efiop
reviewed
Jan 6, 2022
|
|
||
| def parts(self, path): | ||
| drive, path = self.flavour.splitdrive(path) | ||
| drive, path = self.flavour.splitdrive(path.rstrip(self.flavour.sep)) |
Contributor
There was a problem hiding this comment.
Could you please add a simple unit test for this? (e.g. create tests/unit/fs/test_path.py for it) This module is kinda experimental, but since we are fixing such things already, it would be great to keep track of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7228
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏