exp init: handle exception properly on missing parameters file #7277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
force-pushed
the
exp-init-params-exception
branch
from
243f4c7 to
c466977
Compare
skshetry
added
A: cli
dberenbaum
reviewed
Jan 19, 2022
Contributor
dberenbaum
left a comment
dberenbaum
left a comment
There was a problem hiding this comment.
Do you think we should link to https://dvc.org/doc/command-reference/params or some other reference or summarize what a parameters file is?
Do you think we should throw an error for an empty params file?
pared
approved these changes
Jan 24, 2022
Collaborator
Author
|
I think we should prioritize #4112 anyway. Meanwhile, I'll add an error for empty params file (in a separate PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Related to #7137.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏