fix ignored job count #7373
Merged
fix ignored job count #7373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `jobs` kwarg was not being passed down properly, resulting in it being ignored in some cases (push/pull/gc)
dtrifiro
force-pushed
the
fix/7319-jobs-count-ignored
branch
from
74918b9 to
dfcb7d2
Compare
dtrifiro
commented
Feb 15, 2022
|
|
||
| odb = self.cloud.get_remote_odb(remote, "gc -c") | ||
| removed = ogc(odb, used_obj_ids) | ||
| removed = ogc(odb, used_obj_ids, jobs=jobs) |
Contributor
Author
There was a problem hiding this comment.
Seems like we were ignoring job count in gc too
Contributor
Author
There was a problem hiding this comment.
I'm looking into how easy it would be to add basic multithreading to gc. For now, it only uses multithreading when listing objects from the odb (odb.all()) using _list_hashes_traverse.
I think it should #5961 should be closed in another PR.
pared
approved these changes
Feb 15, 2022
efiop
reviewed
Feb 18, 2022
|
|
||
| def test_cloud_cli(tmp_dir, dvc, remote): | ||
| args = ["-v", "-j", "2"] | ||
| def test_cloud_cli(tmp_dir, dvc, remote, mocker): |
Contributor
There was a problem hiding this comment.
This test is getting crazier and crazier :) We'll get rid of it when we have lower level testing in dvc-data/objects.
efiop
approved these changes
Feb 18, 2022
iesahin
pushed a commit
to treeverse/dvc.org
that referenced
this pull request
Mar 3, 2022
Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> As [2.9.5](https://github.com/iterative/dvc/releases/tag/2.9.5) includes treeverse/dvc#7373, we can merge this now.
iesahin
pushed a commit
to treeverse/dvc.org
that referenced
this pull request
Apr 11, 2022
Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> As [2.9.5](https://github.com/iterative/dvc/releases/tag/2.9.5) includes treeverse/dvc#7373, we can merge this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jobskwarg was not being passed on properlyFixes #7319