config: Reraise ConfigError from ConfigObjError.
#8802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amritghimire
approved these changes
Jan 12, 2023
skshetry
reviewed
Jan 12, 2023
Comment on lines
+90
to
+93
| mocker.patch( | ||
| "configobj.ConfigObj", | ||
| side_effect=ConfigObjError(), | ||
| ) |
Collaborator
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Just copied from the already existing test above 🤷
Collaborator
There was a problem hiding this comment.
yeah, what are they going to do? Make a new release? Probably not anytime soon. 😄
Codecov ReportBase: 93.64% // Head: 93.63% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8802 +/- ##
==========================================
- Coverage 93.64% 93.63% -0.02%
==========================================
Files 456 456
Lines 36110 36119 +9
Branches 5227 5230 +3
==========================================
+ Hits 33815 33819 +4
- Misses 1799 1802 +3
- Partials 496 498 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
skshetry
approved these changes
Jan 12, 2023
daavoo
force-pushed
the
wrap-configobj-error
branch
from
a5c53ff to
4901cfd
Compare
daavoo
added
product: Studio
and removed
product: VSCode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8801