Skip to content

Conversation

@daavoo
Copy link
Contributor

@daavoo daavoo commented Jan 16, 2023

Closes #8803

@daavoo daavoo requested a review from a team January 16, 2023 11:58
@daavoo daavoo linked an issue Jan 16, 2023 that may be closed by this pull request
@daavoo daavoo self-assigned this Jan 16, 2023
@daavoo daavoo added A: params Related to dvc params bugfix fixes bug labels Jan 16, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 93.59% // Head: 93.25% // Decreases project coverage by -0.35% ⚠️

Coverage data is based on head (89b7e24) compared to base (5f558d0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8823      +/-   ##
==========================================
- Coverage   93.59%   93.25%   -0.35%     
==========================================
  Files         453      453              
  Lines       36139    36152      +13     
  Branches     5250     5251       +1     
==========================================
- Hits        33825    33713     -112     
- Misses       1811     1906      +95     
- Partials      503      533      +30     
Impacted Files Coverage Δ
dvc/dependency/param.py 96.52% <100.00%> (+0.03%) ⬆️
tests/unit/dependency/test_params.py 100.00% <100.00%> (ø)
tests/func/test_unprotect.py 78.57% <0.00%> (-21.43%) ⬇️
tests/unit/utils/test_utils.py 83.33% <0.00%> (-16.67%) ⬇️
tests/unit/test_daemon.py 85.18% <0.00%> (-14.82%) ⬇️
dvc/utils/fs.py 83.63% <0.00%> (-10.91%) ⬇️
tests/unit/proc/test_manager.py 89.28% <0.00%> (-10.72%) ⬇️
dvc/proc/manager.py 66.66% <0.00%> (-9.68%) ⬇️
tests/unit/utils/test_fs.py 88.42% <0.00%> (-9.48%) ⬇️
dvc/analytics.py 88.05% <0.00%> (-7.47%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry skshetry force-pushed the 8803-dvc-repro-tuples-in-parameters-are-always-marked-as-modified branch from 7645d6d to c140504 Compare January 17, 2023 08:31
@daavoo daavoo force-pushed the 8803-dvc-repro-tuples-in-parameters-are-always-marked-as-modified branch from c140504 to 94da843 Compare January 17, 2023 09:27
@daavoo daavoo force-pushed the 8803-dvc-repro-tuples-in-parameters-are-always-marked-as-modified branch from 94da843 to 018efb8 Compare January 18, 2023 16:50
@daavoo daavoo requested review from karajan1001 and pmrowla January 18, 2023 16:52
Closes #8803

Update dvc/dependency/param.py

Co-authored-by: Peter Rowlands (변기호) <peter@pmrowla.com>
@daavoo daavoo force-pushed the 8803-dvc-repro-tuples-in-parameters-are-always-marked-as-modified branch from 018efb8 to 89b7e24 Compare January 18, 2023 16:52
@daavoo daavoo merged commit dd2d2dc into main Jan 19, 2023
@daavoo daavoo deleted the 8803-dvc-repro-tuples-in-parameters-are-always-marked-as-modified branch January 19, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: params Related to dvc params bugfix fixes bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dvc repro: Tuples in parameters are always marked as modified

3 participants