Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser back button not working correctly #110

Merged
merged 2 commits into from
Oct 27, 2017

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Oct 27, 2017

Fix #94.

Signed-off-by: Joe Farro joef@uber.com

Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 69.736% when pulling df3104a on issue-94-browser-back-button into 79d262d on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.91% when pulling df3104a on issue-94-browser-back-button into 79d262d on master.

Copy link
Contributor

@black-adder black-adder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, the classic replace "routing" with "router" trick.

@tiffon tiffon merged commit 899c8e7 into master Oct 27, 2017
@yurishkuro yurishkuro deleted the issue-94-browser-back-button branch January 29, 2020 15:11
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Joe Farro <joef@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
…ser-back-button

Fix browser back button not working correctly
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants