ECS isn't included with PHP8 image

[Pen-y-Fan]

Thanks for this great resource!

I have just pulled the php8 image and tried to set up my dev environment, phpstan, ECS, PHPUnit etc. But was unable to get ECS to run, I searched the /tools/ directory and it is not installed. I manually installed it Ok:

cd /tools/.composer/
composer global require symplify/easy-coding-standard-prefixed

Note: The prefixed version is a phar to help with conflicts.

I pulled the PHP7.4 image and ECS was installed fine.

I read issue #283 , if there are compatibility issues with other PHP8 packages, would it be possible to add the known issues to the readme?

I would be happy to update the README, if this will help. I can see the installed packages on PHP7.4 and PHP8, thanks to your helpful available packages list. I wish I had spotted that earlier :)

Possibly your output can be turned into a pivot table and create a summary:

Package	php7.4	php8.0
analyze	✓
behat	✓	✓
behat	✓	✓
behat	✓	✓
box	✓
behat	✓	✓
box	✓
box-legacy	✓	✓
churn	✓	✓
composer	✓	✓
composer-bin-plugin	✓	✓
composer-normalize	✓	✓
composer-unused	✓	✓
dephpend	✓	✓
deprecation-detector	✓	✓
deptrac	✓	✓
diffFilter	✓
doctrine-psalm-plugin	✓
ecs	✓
infection	✓	✓
larastan	✓	✓
local-php-security-checker	✓	✓
parallel-lint	✓
paratest	✓
pdepend	✓	✓
phan	✓	✓
php-coupling-detector	✓
php-cs-fixer	✓	✓
php-formatter	✓
php-semver-checker	✓	✓
phpa	✓	✓
phpat	✓
phpbench	✓	✓
phpca	✓	✓
phpcb	✓	✓
phpcbf	✓	✓
phpcov	✓	✓
phpcpd	✓	✓
phpcs	✓	✓
phpda	✓	✓
phpdd	✓	✓
phpdoc-to-typehint	✓	✓
phpDocumentor	✓
phpinsights	✓
phplint	✓	✓
phploc	✓	✓
phpmd	✓	✓
phpmetrics	✓	✓
phpmnd	✓
phpspec	✓	✓
phpstan	✓	✓
phpstan-beberlei-assert	✓	✓
phpstan-deprecation-rules	✓	✓
phpstan-doctrine	✓	✓
phpstan-ergebnis-rules	✓	✓
phpstan-exception-rules	✓	✓
phpstan-phpunit	✓	✓
phpstan-strict-rules	✓	✓
phpstan-symfony	✓	✓
phpstan-webmozart-assert	✓	✓
phpunit	✓	✓
phpunit-5	✓
phpunit-7	✓
phpunit-8	✓	✓
psalm	✓	✓
psecio-parse	✓	✓
rector	✓
roave-backward-compatibility-check	✓
simple-phpunit	✓	✓
twig-lint	✓	✓
twigcs	✓	✓
yaml-lint	✓	✓

[jakzal]

At the time of creating the PHP 8 image, ecs didn't support PHP 8. Let's see if it supports it now: jakzal/toolbox#355

If you'd like to help, it might be a good idea to go through the tools tagged with exclude-php:8.0 and verify if any of them started to support PHP 8 yet.

I like your idea with the table presentation of tools. You'd need to update the task that generates it here: https://github.com/jakzal/toolbox/blob/master/bin/devkit.php#L70-L89

[Pen-y-Fan]

Thanks for your reply and adding ecs looks successful 👍

I've taken a look at the available tools writer. I'll create a PR shortly.

[Pen-y-Fan]

jakzal/toolbox#356 created. Thanks for your direction, I wouldn't have done it without your help. I think it looks brilliant 😀, it will help others, I hope you like it too.

[nealio82]

Off-topic, but... I'm fascinated by the mental image of a mountain sitting down in front of a computer to make a PR

[Pen-y-Fan]

@nealio82 , for me Pen y Fan is a local mountain, the image is taken at the summit. I chose it to be a challenge, something that is an achievable target.

[jakzal]

v1.52* and latest images are now being built. ecs will be available in these builds.

@Pen-y-Fan if you'd like to continue your great contributions, feel free to remove exclude-php:8.0 tags for tools that caught up and support PHP 8.0 now ;)

[nealio82]

I love Pen-y-Fan. It was the first mountain I climbed (about 25 years ago), and the first one I dragged my wife up. We go back to it every-so-often as a favourite. The horseshoe ridge is a great extended route (and don't forget to detour to the diving board at Fan-y-Big - it's tougher but it's worth it). Incidentally, my avatar is from the summit of Snowdon.

[jakzal]

ecs is now part of php 8 images