You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, the hdr_len field of FrameGrantW and FrameGrantR is of type usize, though the only possible values are 0..=9, as these are the only possible lengths of the header.
It would be good to change the type from usize to u8, and handle this appropriately in all handling code. This should be as easy as changing the types, and fixing any compilation errors. We should add debug asserts as well to ensure there have not been any logic errors.
The text was updated successfully, but these errors were encountered:
* Reduce size of Grants for Framed operation #47
* using `into` instead of `as` for casting smaller sized variables safely
* avoid some additional casting
* :( a typo
Right now, the
hdr_len
field ofFrameGrantW
andFrameGrantR
is of typeusize
, though the only possible values are0..=9
, as these are the only possible lengths of the header.It would be good to change the type from
usize
tou8
, and handle this appropriately in all handling code. This should be as easy as changing the types, and fixing any compilation errors. We should add debug asserts as well to ensure there have not been any logic errors.The text was updated successfully, but these errors were encountered: