fix: benchmark with custom model param

Author: louis-jan

cortex-js/src/infrastructure/commanders/benchmark.command.ts

@@ -1,6 +1,9 @@
 import { CommandRunner, SubCommand, Option } from 'nest-commander';
 import { BenchmarkCliUsecases } from './usecases/benchmark.cli.usecases';
-import { BenchmarkConfig } from './types/benchmark-config.interface';
+import {
+  BenchmarkConfig,
+  ParametersConfig,
+} from './types/benchmark-config.interface';
 
 @SubCommand({
   name: 'benchmark',
@@ -20,10 +23,12 @@ export class BenchmarkCommand extends CommandRunner {
     passedParams: string[],
     options?: Partial<BenchmarkConfig>,
   ): Promise<void> {
-    return this.benchmarkUsecases.benchmark({
-      ...options,
-      ...(passedParams[0] ? { modelId: passedParams[0] } : {}),
-    });
+    return this.benchmarkUsecases.benchmark(
+      options ?? {},
+      passedParams[0]
+        ? ({ model: passedParams[0] } as ParametersConfig)
+        : undefined,
+    );
   }
 
   @Option({

cortex-js/src/infrastructure/commanders/types/benchmark-config.interface.ts

@@ -1,21 +1,25 @@
 import { ChatCompletionMessageParam } from 'openai/resources';
 
+export interface ApiConfig {
+  base_url: string;
+  api_key: string;
+  parameters: ParametersConfig;
+}
+
+export interface ParametersConfig {
+  messages: ChatCompletionMessageParam[];
+  model: string;
+  stream?: boolean;
+  max_tokens?: number;
+  stop?: string[];
+  frequency_penalty?: number;
+  presence_penalty?: number;
+  temperature?: number;
+  top_p?: number;
+}
+
 export interface BenchmarkConfig {
-  api: {
-    base_url: string;
-    api_key: string;
-    parameters: {
-      messages: ChatCompletionMessageParam[];
-      model: string;
-      stream?: boolean;
-      max_tokens?: number;
-      stop?: string[];
-      frequency_penalty?: number;
-      presence_penalty?: number;
-      temperature?: number;
-      top_p?: number;
-    };
-  };
+  api: ApiConfig;
   prompts?: {
     min: number;
     max: number;

cortex-js/src/infrastructure/commanders/usecases/benchmark.cli.usecases.ts

@@ -8,7 +8,10 @@ import { FileManagerService } from '@/infrastructure/services/file-manager/file-
 import { join } from 'path';
 import { ModelsCliUsecases } from './models.cli.usecases';
 import { spawn } from 'child_process';
-import { BenchmarkConfig } from '@commanders/types/benchmark-config.interface';
+import {
+  BenchmarkConfig,
+  ParametersConfig,
+} from '@commanders/types/benchmark-config.interface';
 import { CortexUsecases } from '@/usecases/cortex/cortex.usecases';
 import { inspect } from 'util';
 import { defaultBenchmarkConfiguration } from '@/infrastructure/constants/benchmark';
@@ -28,13 +31,17 @@ export class BenchmarkCliUsecases {
   /**
    * Benchmark and analyze the performance of a specific AI model using a variety of system resources
    */
-  async benchmark(options: Partial<BenchmarkConfig>) {
+  async benchmark(
+    options: Partial<BenchmarkConfig>,
+    params?: ParametersConfig,
+  ) {
     return this.getBenchmarkConfig().then((config) => {
       this.config = {
         ...config,
         ...options,
       };
 
+      const model = params?.model ?? this.config.api.parameters.model;
       // TODO: Using OpenAI client or Cortex client to benchmark?
       this.openai = new OpenAI({
         apiKey: this.config.api.api_key,
@@ -49,15 +56,13 @@ export class BenchmarkCliUsecases {
 
       return this.cortexUsecases
         .startCortex()
-        .then(() =>
-          this.modelsCliUsecases.startModel(this.config.api.parameters.model),
-        )
+        .then(() => this.modelsCliUsecases.startModel(model))
         .then(() =>
           this.psUsecases
             .getModels()
             .then((models) =>
               models.find(
-                (e) => e.modelId === this.config.api.parameters.model,
+                (e) => e.modelId === model,
               ),
             ),
         )