Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punt useOptimizedSelector to separate package #3124

Closed

Conversation

johnrom
Copy link
Collaborator

@johnrom johnrom commented Mar 25, 2021

I am willing to take on the maintenance for this, since it could be useful for more than Formik. And it's very small!

https://www.npmjs.com/package/use-optimized-selector

johnrom and others added 26 commits March 8, 2021 18:28
Added Ref State.
Added useSelectorComparer.
Starting to build subscriptions.
use-subscriptions might not work in React 17? Seems returning the previous value doesn't bail out the render.
Sync up formik-native and formik for v3.
…te will do. If we call our own reducer then use useReducer dispatch, `state.values !== getState().values`.
…ormikReducerState + FormikComputedState.

Add Fixtures and Tutorial code to /app.
Consolidate State and Add Tutorial + Fixtures.
@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2021

🦋 Changeset detected

Latest commit: 39f7cfd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
formik-native Major
formik Major
app Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 25, 2021

@johnrom is attempting to deploy a commit to the Formium Team on Vercel.

A member of the Team first needs to authorize it.

@johnrom johnrom mentioned this pull request Mar 25, 2021
1 task
# Conflicts:
#	packages/formik/src/hooks/useFormikState.ts
…API.

Moved FieldHelpers to their own hooks.
Removed batchedUpdates since we use an Effect.
Some minor type fixes, code and documentation cleanup.
@github-actions
Copy link
Contributor

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days

@github-actions github-actions bot added the stale label May 14, 2021
@johnrom johnrom removed the stale label May 14, 2021
@johnrom
Copy link
Collaborator Author

johnrom commented Jun 7, 2021

closed in favor of #3231

@johnrom johnrom closed this Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants