-
Notifications
You must be signed in to change notification settings - Fork 0
Add Prevent to codeowners #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
# Prevent | ||
/src/sentry/prevent/ @getsentry/prevent | ||
/src/sentry/overwatch/ @getsentry/prevent | ||
/src/sentry/overwatch_webhooks/ @getsentry/prevent | ||
/static/app/components/prevent/ @getsentry/prevent | ||
/static/app/views/prevent/ @getsentry/prevent | ||
/static/app/views/nav/secondary/sections/prevent/ @getsentry/prevent | ||
# End of Prevent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[CompanyBestPractice]
The section comment inconsistency could cause confusion when navigating the CODEOWNERS file. The opening section uses # Prevent
while the closing section uses # End of Prevent
, but other sections in the file use ## Prevent
and ## End of [Section Name]
format (e.g., ## Crons
and ## End Crons
). Consider updating for consistency:
Suggested Change
# Prevent | |
/src/sentry/prevent/ @getsentry/prevent | |
/src/sentry/overwatch/ @getsentry/prevent | |
/src/sentry/overwatch_webhooks/ @getsentry/prevent | |
/static/app/components/prevent/ @getsentry/prevent | |
/static/app/views/prevent/ @getsentry/prevent | |
/static/app/views/nav/secondary/sections/prevent/ @getsentry/prevent | |
# End of Prevent | |
## Prevent | |
/src/sentry/prevent/ @getsentry/prevent | |
/src/sentry/overwatch/ @getsentry/prevent | |
/src/sentry/overwatch_webhooks/ @getsentry/prevent | |
/static/app/components/prevent/ @getsentry/prevent | |
/static/app/views/prevent/ @getsentry/prevent | |
/static/app/views/nav/secondary/sections/prevent/ @getsentry/prevent | |
## End of Prevent |
⚡ Committable suggestion
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Context for Agents
[**CompanyBestPractice**]
The section comment inconsistency could cause confusion when navigating the CODEOWNERS file. The opening section uses `# Prevent` while the closing section uses `# End of Prevent`, but other sections in the file use `## Prevent` and `## End of [Section Name]` format (e.g., `## Crons` and `## End Crons`). Consider updating for consistency:
<details>
<summary>Suggested Change</summary>
```suggestion
## Prevent
/src/sentry/prevent/ @getsentry/prevent
/src/sentry/overwatch/ @getsentry/prevent
/src/sentry/overwatch_webhooks/ @getsentry/prevent
/static/app/components/prevent/ @getsentry/prevent
/static/app/views/prevent/ @getsentry/prevent
/static/app/views/nav/secondary/sections/prevent/ @getsentry/prevent
## End of Prevent
```
⚡ **Committable suggestion**
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
</details>
File: .github/CODEOWNERS
Line: 694
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
\n\n---\nCopied from getsentry#100897\nOriginal PR: getsentry#100897