Skip to content

Conversation

jasonyuezhang
Copy link
Owner

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
\n\n---\nCopied from getsentry#100897\nOriginal PR: getsentry#100897

Comment on lines +687 to +694
# Prevent
/src/sentry/prevent/ @getsentry/prevent
/src/sentry/overwatch/ @getsentry/prevent
/src/sentry/overwatch_webhooks/ @getsentry/prevent
/static/app/components/prevent/ @getsentry/prevent
/static/app/views/prevent/ @getsentry/prevent
/static/app/views/nav/secondary/sections/prevent/ @getsentry/prevent
# End of Prevent

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[CompanyBestPractice]

The section comment inconsistency could cause confusion when navigating the CODEOWNERS file. The opening section uses # Prevent while the closing section uses # End of Prevent, but other sections in the file use ## Prevent and ## End of [Section Name] format (e.g., ## Crons and ## End Crons). Consider updating for consistency:

Suggested Change
Suggested change
# Prevent
/src/sentry/prevent/ @getsentry/prevent
/src/sentry/overwatch/ @getsentry/prevent
/src/sentry/overwatch_webhooks/ @getsentry/prevent
/static/app/components/prevent/ @getsentry/prevent
/static/app/views/prevent/ @getsentry/prevent
/static/app/views/nav/secondary/sections/prevent/ @getsentry/prevent
# End of Prevent
## Prevent
/src/sentry/prevent/ @getsentry/prevent
/src/sentry/overwatch/ @getsentry/prevent
/src/sentry/overwatch_webhooks/ @getsentry/prevent
/static/app/components/prevent/ @getsentry/prevent
/static/app/views/prevent/ @getsentry/prevent
/static/app/views/nav/secondary/sections/prevent/ @getsentry/prevent
## End of Prevent

Committable suggestion

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Context for Agents
[**CompanyBestPractice**]

The section comment inconsistency could cause confusion when navigating the CODEOWNERS file. The opening section uses `# Prevent` while the closing section uses `# End of Prevent`, but other sections in the file use `## Prevent` and `## End of [Section Name]` format (e.g., `## Crons` and `## End Crons`). Consider updating for consistency:

<details>
<summary>Suggested Change</summary>

```suggestion
## Prevent
/src/sentry/prevent/                                      @getsentry/prevent
/src/sentry/overwatch/                                    @getsentry/prevent
/src/sentry/overwatch_webhooks/                           @getsentry/prevent
/static/app/components/prevent/                           @getsentry/prevent
/static/app/views/prevent/                                @getsentry/prevent
/static/app/views/nav/secondary/sections/prevent/         @getsentry/prevent
## End of Prevent
```

⚡ **Committable suggestion**

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

</details>

File: .github/CODEOWNERS
Line: 694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants