Skip to content

fix(eco): Report integration config errors to users when testing actions #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(eco): Report integration config errors to users when testing actions #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
515b072
fix(eco): Allows configuration/bug problems to flow up via the test r…
GabeVillalobos Oct 2, 2025
283ad91
Updates ACI test action exception handling.
GabeVillalobos Oct 2, 2025
a337772
Fixes small bug with error reporting
GabeVillalobos Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/sentry/api/endpoints/project_rule_actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@
from sentry.notifications.types import TEST_NOTIFICATION_ID
from sentry.rules.processing.processor import activate_downstream_actions
from sentry.services.eventstore.models import GroupEvent
from sentry.shared_integrations.exceptions import IntegrationFormError
from sentry.shared_integrations.exceptions import (
IntegrationConfigurationError,
IntegrationFormError,
)
from sentry.utils.samples import create_sample_event
from sentry.workflow_engine.endpoints.utils.test_fire_action import test_fire_action
from sentry.workflow_engine.migration_helpers.rule_action import (
Expand All @@ -27,6 +30,8 @@

logger = logging.getLogger(__name__)

REPORTABLE_ERROR_TYPES = (IntegrationFormError, IntegrationConfigurationError)


@region_silo_endpoint
class ProjectRuleActionsEndpoint(ProjectEndpoint):
Expand Down Expand Up @@ -109,7 +114,7 @@ def execute_future_on_test_event(

# safe_execute logs these as exceptions, which can result in
# noisy sentry issues, so log with a warning instead.
if isinstance(exc, IntegrationFormError):
if isinstance(exc, REPORTABLE_ERROR_TYPES):
logger.warning(
"%s.test_alert.integration_error", callback_name, extra={"exc": exc}
)
Expand Down Expand Up @@ -177,9 +182,12 @@ def execute_future_on_test_event_workflow_engine(
action.id = TEST_NOTIFICATION_ID
# Annotate the action with the workflow id
setattr(action, "workflow_id", workflow.id)
except Exception as e:
except REPORTABLE_ERROR_TYPES as e:
action_exceptions.append(str(e))
sentry_sdk.capture_exception(e)
continue
except Exception as e:
error_id = sentry_sdk.capture_exception(e)
action_exceptions.append(f"An unexpected error occurred. Error ID: '{error_id}'")
continue

action_exceptions.extend(test_fire_action(action, event_data, detector))
Expand Down