Update recommended Android proguard rules #1690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With R8 fullMode enabled, classes that extend from `com.sun.jna.*` are all removed, so we should be explicit to include those.
|
Makes sense to me, might be overreaching, but the overhead should be minimal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With R8 fullMode enabled, classes that extend from
com.sun.jna.*are all removed, so we should be explicit to include those.We discovered this in mozilla-mobile/reference-browser#3885 and our patch verified that updating our proguard rules resolve the problem: mozilla/application-services#6979
Additionally, shipping a consumer proguard file would allow consumers to benefit from proguard changes supplied by JNA. Mentioning this is only for your consideration. 🙂