Skip to content

Include classes that extend from JNA Structure in proguard consumer rules #6979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2025
Merged

Include classes that extend from JNA Structure in proguard consumer rules #6979

merged 1 commit into from
Sep 27, 2025

Conversation

jonalmeida
Copy link
Collaborator

Specifically, I found that com.sun.jna.Structure ones via RustBuffer that seem to be removed from Android when using R8 fullMode

Fixes mozilla-mobile/reference-browser#3885 and includes upstreaming the Nimbus RustBuffer rules as well.

---

Does not contain breaking changes, but I can add a changelog entry if that's the right approach for this type of patch.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@jonalmeida
Include classes that extend from JNA Structure in proguard consumer r…
9381175 
…ules

Specifically, I found that `com.sun.jna.Structure` ones via `RustBuffer` that seem to be removed from Android when using [R8 fullMode][0]

Fixes mozilla-mobile/reference-browser#3885 and includes upstreaming the Nimbus RustBuffer rules as well.

[0]: https://developer.android.com/topic/performance/app-optimization/enable-app-optimization#full-mode
@rvandermeulen rvandermeulen added this pull request to the merge queue Sep 27, 2025
Merged via the queue into main with commit f1391e5 Sep 27, 2025
13 checks passed
@rvandermeulen rvandermeulen deleted the refbrowser-3886 branch September 27, 2025 14:44
This was referenced Sep 30, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvandermeulen rvandermeulen rvandermeulen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on startup from nullptr in mozilla.appservices.init_rust_components.UniffiLib.uniffi_init_rust_components_fn_func_initialize
2 participants
@jonalmeida @rvandermeulen