Added tests to verify if resources exist in classpath #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeandersonbc
commented
Jun 4, 2018
| * @author Jeanderson Candido | ||
| * | ||
| */ | ||
| public class ReporterResourcesTest extends TestJPF { |
There was a problem hiding this comment.
Although it wasn't required, I extended TestJPF to keep this working on the Ant build.
If you have any suggestions, please, let me know so I can update this pull request with your suggestions.
|
I agree that the test should pass if the two files exist. The contents of
the files is not important (and changes too often to be useful to be
checked in a test).
If it's not too difficult, I'd like the test to use the actual git hash
rather than just a mock. The repo hash code is something we've lost
recently when moving from hg to git, so it makes sense to add it back in
the context of this project.
It also makes debugging third-party bug reports a lot easier.
Jeanderson Barros Candido wrote:
… @cyrille-artho <https://github.com/cyrille-artho>, I guess this is all we
need to check if build.properties and .version exist.
Note that the test is failing because .version doesn't exist yet.
---------------------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
#76
Commit Summary
* Added minimal Java main to debug Reporter (#75)
* Added failing test due to missing .version file (#75)
File Changes
* *A* src/tests/ReporterResourcesTest.java
<https://github.com/javapathfinder/jpf-core/pull/76/files#diff-0> (32)
Patch Links:
* https://github.com/javapathfinder/jpf-core/pull/76.patch
* https://github.com/javapathfinder/jpf-core/pull/76.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#76>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG9eR-ynIUDmdQV5gD_3PWJTD9t4GSX4ks5t5XxcgaJpZM4UZkNy>.
--
Regards,
Cyrille Artho - http://artho.com/
The cost of freedom is eternal vigilance.
-- Thomas Jefferson
|
|
@cyrille-artho I think everything is working now. Any changes or improvements? After merging this, I believe I can start on generating the build properties on Gradle. Currently, it is just copying an outdated file (must open an issue for that) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cyrille-artho, I guess this is all we need to check if build.properties and .version exist.
Note that the test is failing because .version doesn't exist yet.