Skip to content

Type Conversions #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2020
Merged

Type Conversions #10

merged 2 commits into from
Jan 20, 2020

Conversation

JoeGab
Copy link
Contributor

@JoeGab JoeGab commented Jan 19, 2020

No description provided.

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Jan 19, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team January 19, 2020 17:10
@iliakan iliakan mentioned this pull request Jan 19, 2020
Open
1H0
1H0 suggested changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@1H0 1H0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Sie.

@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Jan 20, 2020
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@JoeGab @1H0
Update 1-js/02-first-steps/06-type-conversions/article.md
7d6b3d7 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@JoeGab
Copy link
Contributor Author

JoeGab commented Jan 20, 2020

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jan 20, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team January 20, 2020 13:06
1H0
1H0 approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@1H0 1H0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels Jan 20, 2020
@1H0 1H0 merged commit 68dfe71 into javascript-tutorial:master Jan 20, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@1H0 1H0 added ready to merge and removed needs +1 One more review needed labels Jan 20, 2020
@JoeGab JoeGab deleted the type_conversions branch January 20, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@1H0 1H0 1H0 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoeGab @javascript-translate-bot @1H0