CSS-animation #3317
Open
CSS-animation #3317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquinelio
reviewed
Jan 3, 2023
| @@ -344,7 +344,7 @@ These values are rarely used, as they represent not a real animation, but rather | |||
|
|
|||
| When the CSS animation finishes, the `transitionend` event triggers. | |||
|
|
|||
| It is widely used to do an action after the animation is done. Also we can join animations. | |||
| It is widely used to do an action after the animation is done and to join multiple animations. | |||
There was a problem hiding this comment.
Needs to be fixed, but I prefer the original structure
Suggested change
| It is widely used to do an action after the animation is done and to join multiple animations. | |
| It is widely used to do an action after the animation is done. We can also join multiple animations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tweaks and improvements:
line 3: more verbose language
line 50:
shorthandis a better description, also addedin the same linefor clarityline 89: grammar fix
line 91: grammar fix
line 144: added
whereasfor clarityline 161: minor tweak
line 165: replaced
thatwiththisbecause it could make more senselines 171,195,233: minor tweaks
line 202: grammar fix
line 225: replaced
huge oneswithhuge valuesto be more specificline 251: minor tweak
line 253: formatting: added spaces
line 304: improvement suggestion: switch action at the beginning
line 324: used the same language as in line 312 for consistency.
line 347: considered that the two sentences belong together, making the idea be clearer
line 441: improved flow
line 444: formatting: removed space
task 2: formatting: added spaces
task 3: description suggestion